Possibly bubble sort algorithm The 2019 Stack Overflow Developer Survey Results Are InHow can I speed up my shell sort?Stable Sort in C#Bubble sort a list of integers for a number of iterationsMerge Sort algorithmExact sort - sorting with few move operationsBubble Sort in Objective-CRobust Bubble Sort in VBAMeasuring the time for the bubble sort algorithmCustom sorting algo / optimized bubble sortBubble and Cocktail sort

What information about me do stores get via my credit card?

Unitary representations of finite groups over finite fields

Cooking pasta in a water boiler

How to notate time signature switching consistently every measure

Why does the nucleus not repel itself?

Falsification in Math vs Science

Geography at the pixel level

A word that means fill it to the required quantity

How do you keep chess fun when your opponent constantly beats you?

What do hard-Brexiteers want with respect to the Irish border?

Does HR tell a hiring manager about salary negotiations?

What do I do when my TA workload is more than expected?

How much of the clove should I use when using big garlic heads?

How do PCB vias affect signal quality?

Why didn't the Event Horizon Telescope team mention Sagittarius A*?

What is the meaning of Triage in Cybersec world?

What is the motivation for a law requiring 2 parties to consent for recording a conversation

What is this sharp, curved notch on my knife for?

How did passengers keep warm on sail ships?

Did any laptop computers have a built-in 5 1/4 inch floppy drive?

What does Linus Torvalds mean when he says that Git "never ever" tracks a file?

Why are there uneven bright areas in this photo of black hole?

Accepted by European university, rejected by all American ones I applied to? Possible reasons?

Old scifi movie from the 50s or 60s with men in solid red uniforms who interrogate a spy from the past



Possibly bubble sort algorithm



The 2019 Stack Overflow Developer Survey Results Are InHow can I speed up my shell sort?Stable Sort in C#Bubble sort a list of integers for a number of iterationsMerge Sort algorithmExact sort - sorting with few move operationsBubble Sort in Objective-CRobust Bubble Sort in VBAMeasuring the time for the bubble sort algorithmCustom sorting algo / optimized bubble sortBubble and Cocktail sort



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








4












$begingroup$


I'm trying to figure out what to call this sorting algorithm:






function sort(array) 
array = array.slice();

for (let i = 0; i < array.length; i++)
for (let j = 0; j < array.length - 1; j++)
if (array[j] > array[i])
//swap
[array[i], array[j]] = [array[j], array[i]]




return array;


console.log(sort([8, 4, 5, 2, 3, 7]));





I wrote it while trying to figure out bubble sort which is a lot different. Tho will have slightly the same running time as the actual bubble sort. I might be wrong :(










share|improve this question









New contributor




Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    4












    $begingroup$


    I'm trying to figure out what to call this sorting algorithm:






    function sort(array) 
    array = array.slice();

    for (let i = 0; i < array.length; i++)
    for (let j = 0; j < array.length - 1; j++)
    if (array[j] > array[i])
    //swap
    [array[i], array[j]] = [array[j], array[i]]




    return array;


    console.log(sort([8, 4, 5, 2, 3, 7]));





    I wrote it while trying to figure out bubble sort which is a lot different. Tho will have slightly the same running time as the actual bubble sort. I might be wrong :(










    share|improve this question









    New contributor




    Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      4












      4








      4


      1



      $begingroup$


      I'm trying to figure out what to call this sorting algorithm:






      function sort(array) 
      array = array.slice();

      for (let i = 0; i < array.length; i++)
      for (let j = 0; j < array.length - 1; j++)
      if (array[j] > array[i])
      //swap
      [array[i], array[j]] = [array[j], array[i]]




      return array;


      console.log(sort([8, 4, 5, 2, 3, 7]));





      I wrote it while trying to figure out bubble sort which is a lot different. Tho will have slightly the same running time as the actual bubble sort. I might be wrong :(










      share|improve this question









      New contributor




      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I'm trying to figure out what to call this sorting algorithm:






      function sort(array) 
      array = array.slice();

      for (let i = 0; i < array.length; i++)
      for (let j = 0; j < array.length - 1; j++)
      if (array[j] > array[i])
      //swap
      [array[i], array[j]] = [array[j], array[i]]




      return array;


      console.log(sort([8, 4, 5, 2, 3, 7]));





      I wrote it while trying to figure out bubble sort which is a lot different. Tho will have slightly the same running time as the actual bubble sort. I might be wrong :(






      function sort(array) 
      array = array.slice();

      for (let i = 0; i < array.length; i++)
      for (let j = 0; j < array.length - 1; j++)
      if (array[j] > array[i])
      //swap
      [array[i], array[j]] = [array[j], array[i]]




      return array;


      console.log(sort([8, 4, 5, 2, 3, 7]));





      function sort(array) 
      array = array.slice();

      for (let i = 0; i < array.length; i++)
      for (let j = 0; j < array.length - 1; j++)
      if (array[j] > array[i])
      //swap
      [array[i], array[j]] = [array[j], array[i]]




      return array;


      console.log(sort([8, 4, 5, 2, 3, 7]));






      javascript algorithm sorting






      share|improve this question









      New contributor




      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited Apr 7 at 16:49









      200_success

      131k17157422




      131k17157422






      New contributor




      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked Apr 7 at 15:46









      Ademola AdegbuyiAdemola Adegbuyi

      1235




      1235




      New contributor




      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Ademola Adegbuyi is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          2 Answers
          2






          active

          oldest

          votes


















          4












          $begingroup$

          To me, that's exactly Bubblesort: it takes care the largest element moves to the end of the array, and then operates on length-1 elements.



          Edit: this does look quite similar to Bubblesort, but - as a diligent reader noticed - is not quite Bubblesort, as the algorithm does not compare (and swap) adjacent elements (which indeed is the main characteristic of Bubblesort). If you replace array[j] > array[i] with array[j] > array[j+1], you will get Bubblesort.



          This implementation will fail if less than two input elements are given (0 or 1) - hint: the array is already sorted in these cases (just add an if).



          A small improvement would be to add a flag in the i loop which records if any swapping happened at all - the outer for loop may terminate if the inner loop didn't perform any swaps. (Time) performance of Bubblesort is considered to be awful in comparison to other algorithms, but it must be noted it's the fastest algorithm on an already sorted array - if you add that flag ;)






          share|improve this answer











          $endgroup$








          • 1




            $begingroup$
            So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
            $endgroup$
            – Ademola Adegbuyi
            Apr 7 at 16:36







          • 1




            $begingroup$
            No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
            $endgroup$
            – 200_success
            Apr 7 at 16:53










          • $begingroup$
            @200_success you are absolutely right - about to edit my answer :)
            $endgroup$
            – jvb
            Apr 7 at 17:58










          • $begingroup$
            @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
            $endgroup$
            – Ilmari Karonen
            Apr 7 at 23:32


















          2












          $begingroup$

          It's not even obvious at a glance that your algorithm really sorts all inputs correctly. In fact, it does, but proving that takes a bit of thought.



          The key insight is that, at the end of each iteration of the outer loop, the elements at positions from 0 to i will be sorted correctly:



          for (let i = 0; i < array.length; i++) 
          for (let j = 0; j < array.length - 1; j++)
          if (array[j] > array[i])
          [array[i], array[j]] = [array[j], array[i]]


          // Invariant: here array[0] to array[i] will be correctly sorted!



          In particular, this invariant will obviously be true at the end of the first iteration, when i == 0. It is then not hard to inductively show that, if this was true at the end of the previous iteration, then it will remain true (with i now one greater than before) after the next one as well. Thus, at the end of the last iteration, with i == array.length - 1, the whole array will be correctly sorted.




          Actually, to achieve this, we only need to iterate the inner loop up to j == i - 1; the iteration with i == j obviously does nothing useful, and any later iterations of the inner loop have no effect on the invariant. (Those iterations can only swap the element currently at index i with a larger one from the tail end of the array, which will still leave array[i] greater than or equal to all its predecessors.) So we can speed up your algorithm by only iterating the inner loop until j == i:



          for (let i = 0; i < array.length; i++) 
          for (let j = 0; j < i; j++)
          if (array[j] > array[i])
          [array[i], array[j]] = [array[j], array[i]]


          // Invariant: here array[0] to array[i] will be correctly sorted!



          With this optimization, your algorithm can be recognized as a form of insertion sort.




          It's generally not the most efficient form of that algorithm, though, since the inner loop does the insertion of array[i] into its correct position somewhat inefficiently. A somewhat more efficient implementation would be something like this:



          for (let i = 1; i < array.length; i++) 
          let j = i, temp = array[i];
          while (j > 0 && array[j - 1] > temp)
          array[j] = array[j - 1];
          j--;

          if (j < i) array[j] = temp;
          // Invariant: here array[0] to array[i] will be correctly sorted!



          By running the inner loop "backwards" we can stop it as soon as we find an element that's ranked lower than the one we're inserting (thus avoiding lots of needless comparisons, especially if the input array is already mostly sorted), and by saving the element to be inserted in a temporary variable, we can replace the swaps with simple assignments.



          The if (j < i) part of the code above is not really necessary, since if j == i, assigning temp back to array[i] would have no effect. That said, it's generally a useful optimization if integer comparisons are cheaper than array assignments, which is usually the case. The same goes for starting the outer loop from let i = 1 instead of let i = 0; the iteration with i == 0 does nothing anyway, so we can safely skip it!






          share|improve this answer









          $endgroup$













            Your Answer





            StackExchange.ifUsing("editor", function ()
            return StackExchange.using("mathjaxEditing", function ()
            StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
            StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
            );
            );
            , "mathjax-editing");

            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );






            Ademola Adegbuyi is a new contributor. Be nice, and check out our Code of Conduct.









            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217017%2fpossibly-bubble-sort-algorithm%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            4












            $begingroup$

            To me, that's exactly Bubblesort: it takes care the largest element moves to the end of the array, and then operates on length-1 elements.



            Edit: this does look quite similar to Bubblesort, but - as a diligent reader noticed - is not quite Bubblesort, as the algorithm does not compare (and swap) adjacent elements (which indeed is the main characteristic of Bubblesort). If you replace array[j] > array[i] with array[j] > array[j+1], you will get Bubblesort.



            This implementation will fail if less than two input elements are given (0 or 1) - hint: the array is already sorted in these cases (just add an if).



            A small improvement would be to add a flag in the i loop which records if any swapping happened at all - the outer for loop may terminate if the inner loop didn't perform any swaps. (Time) performance of Bubblesort is considered to be awful in comparison to other algorithms, but it must be noted it's the fastest algorithm on an already sorted array - if you add that flag ;)






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
              $endgroup$
              – Ademola Adegbuyi
              Apr 7 at 16:36







            • 1




              $begingroup$
              No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
              $endgroup$
              – 200_success
              Apr 7 at 16:53










            • $begingroup$
              @200_success you are absolutely right - about to edit my answer :)
              $endgroup$
              – jvb
              Apr 7 at 17:58










            • $begingroup$
              @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
              $endgroup$
              – Ilmari Karonen
              Apr 7 at 23:32















            4












            $begingroup$

            To me, that's exactly Bubblesort: it takes care the largest element moves to the end of the array, and then operates on length-1 elements.



            Edit: this does look quite similar to Bubblesort, but - as a diligent reader noticed - is not quite Bubblesort, as the algorithm does not compare (and swap) adjacent elements (which indeed is the main characteristic of Bubblesort). If you replace array[j] > array[i] with array[j] > array[j+1], you will get Bubblesort.



            This implementation will fail if less than two input elements are given (0 or 1) - hint: the array is already sorted in these cases (just add an if).



            A small improvement would be to add a flag in the i loop which records if any swapping happened at all - the outer for loop may terminate if the inner loop didn't perform any swaps. (Time) performance of Bubblesort is considered to be awful in comparison to other algorithms, but it must be noted it's the fastest algorithm on an already sorted array - if you add that flag ;)






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
              $endgroup$
              – Ademola Adegbuyi
              Apr 7 at 16:36







            • 1




              $begingroup$
              No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
              $endgroup$
              – 200_success
              Apr 7 at 16:53










            • $begingroup$
              @200_success you are absolutely right - about to edit my answer :)
              $endgroup$
              – jvb
              Apr 7 at 17:58










            • $begingroup$
              @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
              $endgroup$
              – Ilmari Karonen
              Apr 7 at 23:32













            4












            4








            4





            $begingroup$

            To me, that's exactly Bubblesort: it takes care the largest element moves to the end of the array, and then operates on length-1 elements.



            Edit: this does look quite similar to Bubblesort, but - as a diligent reader noticed - is not quite Bubblesort, as the algorithm does not compare (and swap) adjacent elements (which indeed is the main characteristic of Bubblesort). If you replace array[j] > array[i] with array[j] > array[j+1], you will get Bubblesort.



            This implementation will fail if less than two input elements are given (0 or 1) - hint: the array is already sorted in these cases (just add an if).



            A small improvement would be to add a flag in the i loop which records if any swapping happened at all - the outer for loop may terminate if the inner loop didn't perform any swaps. (Time) performance of Bubblesort is considered to be awful in comparison to other algorithms, but it must be noted it's the fastest algorithm on an already sorted array - if you add that flag ;)






            share|improve this answer











            $endgroup$



            To me, that's exactly Bubblesort: it takes care the largest element moves to the end of the array, and then operates on length-1 elements.



            Edit: this does look quite similar to Bubblesort, but - as a diligent reader noticed - is not quite Bubblesort, as the algorithm does not compare (and swap) adjacent elements (which indeed is the main characteristic of Bubblesort). If you replace array[j] > array[i] with array[j] > array[j+1], you will get Bubblesort.



            This implementation will fail if less than two input elements are given (0 or 1) - hint: the array is already sorted in these cases (just add an if).



            A small improvement would be to add a flag in the i loop which records if any swapping happened at all - the outer for loop may terminate if the inner loop didn't perform any swaps. (Time) performance of Bubblesort is considered to be awful in comparison to other algorithms, but it must be noted it's the fastest algorithm on an already sorted array - if you add that flag ;)







            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited Apr 7 at 18:05

























            answered Apr 7 at 16:11









            jvbjvb

            899210




            899210







            • 1




              $begingroup$
              So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
              $endgroup$
              – Ademola Adegbuyi
              Apr 7 at 16:36







            • 1




              $begingroup$
              No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
              $endgroup$
              – 200_success
              Apr 7 at 16:53










            • $begingroup$
              @200_success you are absolutely right - about to edit my answer :)
              $endgroup$
              – jvb
              Apr 7 at 17:58










            • $begingroup$
              @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
              $endgroup$
              – Ilmari Karonen
              Apr 7 at 23:32












            • 1




              $begingroup$
              So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
              $endgroup$
              – Ademola Adegbuyi
              Apr 7 at 16:36







            • 1




              $begingroup$
              No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
              $endgroup$
              – 200_success
              Apr 7 at 16:53










            • $begingroup$
              @200_success you are absolutely right - about to edit my answer :)
              $endgroup$
              – jvb
              Apr 7 at 17:58










            • $begingroup$
              @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
              $endgroup$
              – Ilmari Karonen
              Apr 7 at 23:32







            1




            1




            $begingroup$
            So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
            $endgroup$
            – Ademola Adegbuyi
            Apr 7 at 16:36





            $begingroup$
            So, I visualized the execution on pythontutor.com. One should "never" use this. It's worse than the unoptimized version of bubble sort. I goes forth and back, which takes more time. Thanks!
            $endgroup$
            – Ademola Adegbuyi
            Apr 7 at 16:36





            1




            1




            $begingroup$
            No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
            $endgroup$
            – 200_success
            Apr 7 at 16:53




            $begingroup$
            No. One of the defining characteristics of Bubble sort is that it swaps adjacent elements — which is not the case with this code.
            $endgroup$
            – 200_success
            Apr 7 at 16:53












            $begingroup$
            @200_success you are absolutely right - about to edit my answer :)
            $endgroup$
            – jvb
            Apr 7 at 17:58




            $begingroup$
            @200_success you are absolutely right - about to edit my answer :)
            $endgroup$
            – jvb
            Apr 7 at 17:58












            $begingroup$
            @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
            $endgroup$
            – Ilmari Karonen
            Apr 7 at 23:32




            $begingroup$
            @200_success: The OP's code is actually a (rather inefficient) variant of insertion sort, with some mostly useless extra shuffling of the tail end of the array thrown in.
            $endgroup$
            – Ilmari Karonen
            Apr 7 at 23:32













            2












            $begingroup$

            It's not even obvious at a glance that your algorithm really sorts all inputs correctly. In fact, it does, but proving that takes a bit of thought.



            The key insight is that, at the end of each iteration of the outer loop, the elements at positions from 0 to i will be sorted correctly:



            for (let i = 0; i < array.length; i++) 
            for (let j = 0; j < array.length - 1; j++)
            if (array[j] > array[i])
            [array[i], array[j]] = [array[j], array[i]]


            // Invariant: here array[0] to array[i] will be correctly sorted!



            In particular, this invariant will obviously be true at the end of the first iteration, when i == 0. It is then not hard to inductively show that, if this was true at the end of the previous iteration, then it will remain true (with i now one greater than before) after the next one as well. Thus, at the end of the last iteration, with i == array.length - 1, the whole array will be correctly sorted.




            Actually, to achieve this, we only need to iterate the inner loop up to j == i - 1; the iteration with i == j obviously does nothing useful, and any later iterations of the inner loop have no effect on the invariant. (Those iterations can only swap the element currently at index i with a larger one from the tail end of the array, which will still leave array[i] greater than or equal to all its predecessors.) So we can speed up your algorithm by only iterating the inner loop until j == i:



            for (let i = 0; i < array.length; i++) 
            for (let j = 0; j < i; j++)
            if (array[j] > array[i])
            [array[i], array[j]] = [array[j], array[i]]


            // Invariant: here array[0] to array[i] will be correctly sorted!



            With this optimization, your algorithm can be recognized as a form of insertion sort.




            It's generally not the most efficient form of that algorithm, though, since the inner loop does the insertion of array[i] into its correct position somewhat inefficiently. A somewhat more efficient implementation would be something like this:



            for (let i = 1; i < array.length; i++) 
            let j = i, temp = array[i];
            while (j > 0 && array[j - 1] > temp)
            array[j] = array[j - 1];
            j--;

            if (j < i) array[j] = temp;
            // Invariant: here array[0] to array[i] will be correctly sorted!



            By running the inner loop "backwards" we can stop it as soon as we find an element that's ranked lower than the one we're inserting (thus avoiding lots of needless comparisons, especially if the input array is already mostly sorted), and by saving the element to be inserted in a temporary variable, we can replace the swaps with simple assignments.



            The if (j < i) part of the code above is not really necessary, since if j == i, assigning temp back to array[i] would have no effect. That said, it's generally a useful optimization if integer comparisons are cheaper than array assignments, which is usually the case. The same goes for starting the outer loop from let i = 1 instead of let i = 0; the iteration with i == 0 does nothing anyway, so we can safely skip it!






            share|improve this answer









            $endgroup$

















              2












              $begingroup$

              It's not even obvious at a glance that your algorithm really sorts all inputs correctly. In fact, it does, but proving that takes a bit of thought.



              The key insight is that, at the end of each iteration of the outer loop, the elements at positions from 0 to i will be sorted correctly:



              for (let i = 0; i < array.length; i++) 
              for (let j = 0; j < array.length - 1; j++)
              if (array[j] > array[i])
              [array[i], array[j]] = [array[j], array[i]]


              // Invariant: here array[0] to array[i] will be correctly sorted!



              In particular, this invariant will obviously be true at the end of the first iteration, when i == 0. It is then not hard to inductively show that, if this was true at the end of the previous iteration, then it will remain true (with i now one greater than before) after the next one as well. Thus, at the end of the last iteration, with i == array.length - 1, the whole array will be correctly sorted.




              Actually, to achieve this, we only need to iterate the inner loop up to j == i - 1; the iteration with i == j obviously does nothing useful, and any later iterations of the inner loop have no effect on the invariant. (Those iterations can only swap the element currently at index i with a larger one from the tail end of the array, which will still leave array[i] greater than or equal to all its predecessors.) So we can speed up your algorithm by only iterating the inner loop until j == i:



              for (let i = 0; i < array.length; i++) 
              for (let j = 0; j < i; j++)
              if (array[j] > array[i])
              [array[i], array[j]] = [array[j], array[i]]


              // Invariant: here array[0] to array[i] will be correctly sorted!



              With this optimization, your algorithm can be recognized as a form of insertion sort.




              It's generally not the most efficient form of that algorithm, though, since the inner loop does the insertion of array[i] into its correct position somewhat inefficiently. A somewhat more efficient implementation would be something like this:



              for (let i = 1; i < array.length; i++) 
              let j = i, temp = array[i];
              while (j > 0 && array[j - 1] > temp)
              array[j] = array[j - 1];
              j--;

              if (j < i) array[j] = temp;
              // Invariant: here array[0] to array[i] will be correctly sorted!



              By running the inner loop "backwards" we can stop it as soon as we find an element that's ranked lower than the one we're inserting (thus avoiding lots of needless comparisons, especially if the input array is already mostly sorted), and by saving the element to be inserted in a temporary variable, we can replace the swaps with simple assignments.



              The if (j < i) part of the code above is not really necessary, since if j == i, assigning temp back to array[i] would have no effect. That said, it's generally a useful optimization if integer comparisons are cheaper than array assignments, which is usually the case. The same goes for starting the outer loop from let i = 1 instead of let i = 0; the iteration with i == 0 does nothing anyway, so we can safely skip it!






              share|improve this answer









              $endgroup$















                2












                2








                2





                $begingroup$

                It's not even obvious at a glance that your algorithm really sorts all inputs correctly. In fact, it does, but proving that takes a bit of thought.



                The key insight is that, at the end of each iteration of the outer loop, the elements at positions from 0 to i will be sorted correctly:



                for (let i = 0; i < array.length; i++) 
                for (let j = 0; j < array.length - 1; j++)
                if (array[j] > array[i])
                [array[i], array[j]] = [array[j], array[i]]


                // Invariant: here array[0] to array[i] will be correctly sorted!



                In particular, this invariant will obviously be true at the end of the first iteration, when i == 0. It is then not hard to inductively show that, if this was true at the end of the previous iteration, then it will remain true (with i now one greater than before) after the next one as well. Thus, at the end of the last iteration, with i == array.length - 1, the whole array will be correctly sorted.




                Actually, to achieve this, we only need to iterate the inner loop up to j == i - 1; the iteration with i == j obviously does nothing useful, and any later iterations of the inner loop have no effect on the invariant. (Those iterations can only swap the element currently at index i with a larger one from the tail end of the array, which will still leave array[i] greater than or equal to all its predecessors.) So we can speed up your algorithm by only iterating the inner loop until j == i:



                for (let i = 0; i < array.length; i++) 
                for (let j = 0; j < i; j++)
                if (array[j] > array[i])
                [array[i], array[j]] = [array[j], array[i]]


                // Invariant: here array[0] to array[i] will be correctly sorted!



                With this optimization, your algorithm can be recognized as a form of insertion sort.




                It's generally not the most efficient form of that algorithm, though, since the inner loop does the insertion of array[i] into its correct position somewhat inefficiently. A somewhat more efficient implementation would be something like this:



                for (let i = 1; i < array.length; i++) 
                let j = i, temp = array[i];
                while (j > 0 && array[j - 1] > temp)
                array[j] = array[j - 1];
                j--;

                if (j < i) array[j] = temp;
                // Invariant: here array[0] to array[i] will be correctly sorted!



                By running the inner loop "backwards" we can stop it as soon as we find an element that's ranked lower than the one we're inserting (thus avoiding lots of needless comparisons, especially if the input array is already mostly sorted), and by saving the element to be inserted in a temporary variable, we can replace the swaps with simple assignments.



                The if (j < i) part of the code above is not really necessary, since if j == i, assigning temp back to array[i] would have no effect. That said, it's generally a useful optimization if integer comparisons are cheaper than array assignments, which is usually the case. The same goes for starting the outer loop from let i = 1 instead of let i = 0; the iteration with i == 0 does nothing anyway, so we can safely skip it!






                share|improve this answer









                $endgroup$



                It's not even obvious at a glance that your algorithm really sorts all inputs correctly. In fact, it does, but proving that takes a bit of thought.



                The key insight is that, at the end of each iteration of the outer loop, the elements at positions from 0 to i will be sorted correctly:



                for (let i = 0; i < array.length; i++) 
                for (let j = 0; j < array.length - 1; j++)
                if (array[j] > array[i])
                [array[i], array[j]] = [array[j], array[i]]


                // Invariant: here array[0] to array[i] will be correctly sorted!



                In particular, this invariant will obviously be true at the end of the first iteration, when i == 0. It is then not hard to inductively show that, if this was true at the end of the previous iteration, then it will remain true (with i now one greater than before) after the next one as well. Thus, at the end of the last iteration, with i == array.length - 1, the whole array will be correctly sorted.




                Actually, to achieve this, we only need to iterate the inner loop up to j == i - 1; the iteration with i == j obviously does nothing useful, and any later iterations of the inner loop have no effect on the invariant. (Those iterations can only swap the element currently at index i with a larger one from the tail end of the array, which will still leave array[i] greater than or equal to all its predecessors.) So we can speed up your algorithm by only iterating the inner loop until j == i:



                for (let i = 0; i < array.length; i++) 
                for (let j = 0; j < i; j++)
                if (array[j] > array[i])
                [array[i], array[j]] = [array[j], array[i]]


                // Invariant: here array[0] to array[i] will be correctly sorted!



                With this optimization, your algorithm can be recognized as a form of insertion sort.




                It's generally not the most efficient form of that algorithm, though, since the inner loop does the insertion of array[i] into its correct position somewhat inefficiently. A somewhat more efficient implementation would be something like this:



                for (let i = 1; i < array.length; i++) 
                let j = i, temp = array[i];
                while (j > 0 && array[j - 1] > temp)
                array[j] = array[j - 1];
                j--;

                if (j < i) array[j] = temp;
                // Invariant: here array[0] to array[i] will be correctly sorted!



                By running the inner loop "backwards" we can stop it as soon as we find an element that's ranked lower than the one we're inserting (thus avoiding lots of needless comparisons, especially if the input array is already mostly sorted), and by saving the element to be inserted in a temporary variable, we can replace the swaps with simple assignments.



                The if (j < i) part of the code above is not really necessary, since if j == i, assigning temp back to array[i] would have no effect. That said, it's generally a useful optimization if integer comparisons are cheaper than array assignments, which is usually the case. The same goes for starting the outer loop from let i = 1 instead of let i = 0; the iteration with i == 0 does nothing anyway, so we can safely skip it!







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Apr 7 at 23:28









                Ilmari KaronenIlmari Karonen

                1,865915




                1,865915




















                    Ademola Adegbuyi is a new contributor. Be nice, and check out our Code of Conduct.









                    draft saved

                    draft discarded


















                    Ademola Adegbuyi is a new contributor. Be nice, and check out our Code of Conduct.












                    Ademola Adegbuyi is a new contributor. Be nice, and check out our Code of Conduct.











                    Ademola Adegbuyi is a new contributor. Be nice, and check out our Code of Conduct.














                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217017%2fpossibly-bubble-sort-algorithm%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Club Baloncesto Breogán Índice Historia | Pavillón | Nome | O Breogán na cultura popular | Xogadores | Adestradores | Presidentes | Palmarés | Historial | Líderes | Notas | Véxase tamén | Menú de navegacióncbbreogan.galCadroGuía oficial da ACB 2009-10, páxina 201Guía oficial ACB 1992, páxina 183. Editorial DB.É de 6.500 espectadores sentados axeitándose á última normativa"Estudiantes Junior, entre as mellores canteiras"o orixinalHemeroteca El Mundo Deportivo, 16 setembro de 1970, páxina 12Historia do BreogánAlfredo Pérez, o último canoneiroHistoria C.B. BreogánHemeroteca de El Mundo DeportivoJimmy Wright, norteamericano do Breogán deixará Lugo por ameazas de morteResultados de Breogán en 1986-87Resultados de Breogán en 1990-91Ficha de Velimir Perasović en acb.comResultados de Breogán en 1994-95Breogán arrasa al Barça. "El Mundo Deportivo", 27 de setembro de 1999, páxina 58CB Breogán - FC BarcelonaA FEB invita a participar nunha nova Liga EuropeaCharlie Bell na prensa estatalMáximos anotadores 2005Tempada 2005-06 : Tódolos Xogadores da Xornada""Non quero pensar nunha man negra, mais pregúntome que está a pasar""o orixinalRaúl López, orgulloso dos xogadores, presume da boa saúde económica do BreogánJulio González confirma que cesa como presidente del BreogánHomenaxe a Lisardo GómezA tempada do rexurdimento celesteEntrevista a Lisardo GómezEl COB dinamita el Pazo para forzar el quinto (69-73)Cafés Candelas, patrocinador del CB Breogán"Suso Lázare, novo presidente do Breogán"o orixinalCafés Candelas Breogán firma el mayor triunfo de la historiaEl Breogán realizará 17 homenajes por su cincuenta aniversario"O Breogán honra ao seu fundador e primeiro presidente"o orixinalMiguel Giao recibiu a homenaxe do PazoHomenaxe aos primeiros gladiadores celestesO home que nos amosa como ver o Breo co corazónTita Franco será homenaxeada polos #50anosdeBreoJulio Vila recibirá unha homenaxe in memoriam polos #50anosdeBreo"O Breogán homenaxeará aos seus aboados máis veteráns"Pechada ovación a «Capi» Sanmartín e Ricardo «Corazón de González»Homenaxe por décadas de informaciónPaco García volve ao Pazo con motivo do 50 aniversario"Resultados y clasificaciones""O Cafés Candelas Breogán, campión da Copa Princesa""O Cafés Candelas Breogán, equipo ACB"C.B. Breogán"Proxecto social"o orixinal"Centros asociados"o orixinalFicha en imdb.comMario Camus trata la recuperación del amor en 'La vieja música', su última película"Páxina web oficial""Club Baloncesto Breogán""C. B. Breogán S.A.D."eehttp://www.fegaba.com

                    Vilaño, A Laracha Índice Patrimonio | Lugares e parroquias | Véxase tamén | Menú de navegación43°14′52″N 8°36′03″O / 43.24775, -8.60070

                    Cegueira Índice Epidemioloxía | Deficiencia visual | Tipos de cegueira | Principais causas de cegueira | Tratamento | Técnicas de adaptación e axudas | Vida dos cegos | Primeiros auxilios | Crenzas respecto das persoas cegas | Crenzas das persoas cegas | O neno deficiente visual | Aspectos psicolóxicos da cegueira | Notas | Véxase tamén | Menú de navegación54.054.154.436928256blindnessDicionario da Real Academia GalegaPortal das Palabras"International Standards: Visual Standards — Aspects and Ranges of Vision Loss with Emphasis on Population Surveys.""Visual impairment and blindness""Presentan un plan para previr a cegueira"o orixinalACCDV Associació Catalana de Cecs i Disminuïts Visuals - PMFTrachoma"Effect of gene therapy on visual function in Leber's congenital amaurosis"1844137110.1056/NEJMoa0802268Cans guía - os mellores amigos dos cegosArquivadoEscola de cans guía para cegos en Mortágua, PortugalArquivado"Tecnología para ciegos y deficientes visuales. Recopilación de recursos gratuitos en la Red""Colorino""‘COL.diesis’, escuchar los sonidos del color""COL.diesis: Transforming Colour into Melody and Implementing the Result in a Colour Sensor Device"o orixinal"Sistema de desarrollo de sinestesia color-sonido para invidentes utilizando un protocolo de audio""Enseñanza táctil - geometría y color. Juegos didácticos para niños ciegos y videntes""Sistema Constanz"L'ocupació laboral dels cecs a l'Estat espanyol està pràcticament equiparada a la de les persones amb visió, entrevista amb Pedro ZuritaONCE (Organización Nacional de Cegos de España)Prevención da cegueiraDescrición de deficiencias visuais (Disc@pnet)Braillín, un boneco atractivo para calquera neno, con ou sen discapacidade, que permite familiarizarse co sistema de escritura e lectura brailleAxudas Técnicas36838ID00897494007150-90057129528256DOID:1432HP:0000618D001766C10.597.751.941.162C97109C0155020